You aren't guarenteed to get a shiny.
There's just a chance to get a shiny. It's still very high, and is most likely over 1/1000 (the current chance is still unknown).
You aren't doing anything wrong. It just takes love, patience, and a Pokemon with Flame Body/Magma Armor.