Looks good. definitely better than some of your earlier teams. still needs some help but mostly just suggestions.
Ampharos: keep all the same but change Shock Wave to either Thunderbolt for Bolt-Beam coverage, or Charge Beam to boost SAtk.
Dragoinaire: Ice isn't as much of a threat due to only having a x2 weakness vs. Dragonites x4. I would use this:
Dragonair @ Eviolite
Trait: Shed Skin
Calm Nature (+SDef, -Atk)
EVs: 252 SAtk/ 148 Def/ 84 SDef
- Draco Meteor
- Ice Beam
this set uses Eviolite to boost NFE Dragonair's Def and SDef. T-Bolt and Ice Beam plus STAB Draco Meteor provide amazing coverage abduction Protect helps scout for harmful moves, and also allows Shed Skin to be abused to heal status and the like.
Arcanine looks good, but use Adamant Nature.
switch Sunny Day (CHOICE BAND, remember?) for Wild Charge, and Solar Beam for Close Combat. you could also use this set with a Life Orb instead.
Snorlax needs some help
Snorlax @ Leftovers
Brave Nature (+Atk, -Spd)
EVs: 180 Atk/ 144 SDef/ 108 Def
- Gyro Ball
- Zen Headbutt
this set uses Snorlax's amazing bulk to take hits and Immunity prevents Toxic interfering with its mission. Brave nature ups Atk and hinders Spd which Snorlax doesn't mind Gyro Ball is more powerful the slower he is. Zen Headbutt covers Fighting Types and has decent coverage plus Flinch chance. Rest is obviously Recovery and Leftovers should keep Lax alive. STAB Explosion is pretty much a last ditch attack but a 325 BP attack that ignores 50% of the opponents Def stat from a 120 base attack Pokemon....that doesn't feel so good.
Gengar looks ok but....
use one of these two sets.
@ Life Orb
same trait (duh)
same nature (Modest is what you meant)
EVs: 252 SAtk/ 252 Spd/ 4 SDef
- Shadow Ball
- Focus Blast
- Destiny Bond
uses Life Orb to beat stuff up. great speed allows Destiny Bond as a Kamikaze finish when Gengar takes a beating.
@ Black Sludge
- Shadow Ball
this exploits the fact that most Pokes only have 1 move to deal with Gengar. Sub makes them use this attack which you the just Disable and rape. you could also swap Sludge for Life Orb abduction Disable for Pain Split. but that your call.
Ok Skarmory I use on my own personal team with Blissey. but here's a Skarm set.
Skarmory @ Rocky Helmet/Leftovers/Shed Shell
Impish Nature (+Def, -SAtk)
EVs: 252 Def/ 180 HP/ 36 HP
- Brave Bird
this set uses Skarm as a Physical Wall. Spikes sets up EH support, Brave Bird is a STAB nightmare for most teams, Whirlwind phazes out setup sweepers and racks up EH damage. Roost is Recovery. item choice is your call, Rocky Helmet + Roost helps stall a Physical Sweeper Leftovers helps keep Skarm alive and Shed Shell stops Magnezone from Magnet Pulling Skarm into a trap the OHKOing it with Thunderbolt.
hope that helps :)