for example, after I use soak on a pichu, will its STAB type change to water instead of electric? or will its electric moves still get STAB boost?
In short, yes. For your example, it's electric moves would not get STAB because they are changed to the water type. If it had water type moves, those would get STAB.