It depends how much sp. attack you have, night shade it guarenteed the same damage every time, where shadow ball might do more damage on some opponents or less on some others, and shadow ball also can have critical hits, and night shade can't. It depends if you like having a guarenteed amount of damage every time, but a level one hundred using night shade can't one hit ko an average level 50