If I give my Bagon 5 Proteins while it holds a Macho Brace, will he gain 100 EVs in Attack instead of 50?
No it wont unfortunately, otherwise it's far to easy. It and other ev items effect come in to place only from gaining exp from a battle. Though the over effect of halfed speed is always active while holding the item.