Does a Pokemon with the ability Suction Cups still give the chain rate that slight boost outside of water and shiny fishing? (Ex. Caves, Grasslands, Etc.)
From Pokémon Emerald onwards, if a Pokémon with Suction Cups is in first place in the player's party (even if fainted), bites will occur more often while fishing. Sticky Hold has the same effect.
It has nothing to do with shiny chances. It only makes chain fishing easier. source