Dont Worry Trachy, Emerald is My Best Moveset Game. Im Not as Good With The 1000s Of New Moves(of gen IV) and I Dont Even Know What Half of them do. So As There Are Good Simple Movesets for Emerald and Gen III.
Swampert: Your Moveset is Good Except Ur Kind Of Missing Ice Beam. Try To Get A Swampert With A Special Attack Nature So It Can Use Ice Beam(YOU NEED ICE BEAM FOR THE ELITE 4! I WOULD know, I Had To Teach It To My Aggron To Beat The E 4 in Emerald) I Would Replace Rock Slide For It(Brick Break Is Too Helpful against the E 4, Taking out Glacia, and Sydney).
Metagross: Your Moveset for metagross is Also Good. The Best You Can Get For It(Especially Sludge Bomb Being Pshysical:)
Salamance: Great, But Ummmmmmm, You Do Know That You Cant Get A Bagon Until You Get Waterfall? And You Get Bagons At Lvl 25 or so, so I your going with Salamacnce, Be Ready To Train It ALOT! But Anyway, Thats A Good Moveset For Salamnce, if it Has A Special Attack Nature(DRAGON MOVES WERE SPECIAL IN GEN III!!) SO YOU NEED A SPECIAL ATTACK NATURE!!
Breloom: First Of all, Great Choice, breloom is By Far, In My Opinion, The Best Fighting Type of All The Games. For A Moveset, I Would Say: Sky Uppercut(focus Punch Takes 2 Turns, plus has low pp, and well, im just not a focus punch fan. You Can Keep it if you want.......), Giga Drain(Great Move, Great Move, But Make Sure, ur Breloom has Decent Sp. Attack:), Headbutt/Strength(for Some Backup), and Swords Dance.
Dusclops: I Would Suggest Teaching it Toxic. Not Much More Needs To Be Said. Thunderbolt is also good for it, along with Ice Beam, Shadow Ball is Good Too, and well, thats about it, for Dusclops:)
Manectric: Amazing Electric Type, amazing........I Would Teach it Thunderbolt, Crunch(egg move), Quick Attack/Return, and Thunder Wave.
Hope This Helps:)