It's one of my favorite Eeveelutions and one of my favorite water types - I can't figure which move is better because they do equal damage.
Vaporeon is a bulky Pokemon so Scald fits it best.
Surf has by far better accuracy, and although Muddy Water has a chance to lower the opponent's Accuracy, Surf is just better.