FLOATZEL
looks good
__
AMPHAROS
many of your other mons is able to learn ice beam. try replacing HP ice with cotton guard since you have put EVs into sp.def
___
WARTORTLE
maybe haze over foresight?
_____
LUDICOLO
as fondant already stated, leech seed is a better choice for ludi. what about this:
ludicolo @damp rock
trait: rain dish
bold nature
252 hp/ 202 def/ 54 sp.def
moveset:
- rain dance
- leech seed
- substitute
- toxic/ surf
most of ludicolos weakness is physical, so its better to put EVs and nature into defense. leech seed steals hp from opposing pokemon and works well together with rain dish, substitute works well with both rain dish and leech seed, giving it back its lost hp. toxic is for… yeah you know toxic and surf is STAB
__
VIVILLION
yes! this is good good GOOD!! love this set. you have already enough rain dancers (after my calculations) so you can replace it with something else if you want. maybe infestation or something? however, vivillon is good whatever you do with it.
_____
for you last pokemon, the clamperl family is great for NU rain. one of these might not be a bad idea:
huntail @life orb/white herb
adamant/ naive nature
trait: swift swim
252 atk/ 252 sp.atk/4 hp
moveset:
shell smash
ice beam
aqua tail
return/ frustration (XD) / giga impact /crunch
so this is a shell smash mixed sweeper set. swift swim makes up for low speed. shell smash takes speed, attack and sp.atk up with two stages but lowers def and sp.def (no worries with white herb), ice beam is coverage, aqua tail is STAB (could suggest waterfall too, but aqua tail is more huntail), return is a good normal type move, giga impact is in an emergency and crunch is since no other of your pokes knows any dark type moves (know its pointless)
another good pokemon could be:
gorebyss@ white herb
modest nature
trait: swift swim
moveset:
- shell smash
- physic
- ice beam
- surf
also shell smash set. surf is STAB, ice beam is coverage, psychic is psyshic not much more to say.
another option could also be the classic "SmashPass"
____
so sorry if this was just terrible D: , but i hope you will follow at least one of my tips