In gen three, it is Swampert but it has a neutral matchup against most of the game
In gen four, definitely Infernape. Fire types are not that common in gen four so that's already a point in its favor and it has incredible high based damage stabs. It's also really fast so that's something and has priority mach punch, which you will rarely need but useful in the early game
In gen five, I think it is Oshawott for the same reasons as Swampert. It mostly has a neutral matchup with the exception of the electric gym
In gen six, I think it is Chespin. I'm not sure on that though
In gen seven, I'm not sure about this but I would say whatever the water type is since it gets the fairy typing and water is a very good type