When planning in-game teams, it's important to consider offensive typing as well as defensive typing. If Toxicroak knew a poison attack, a fighting attack, and x-scissor, then it will be pretty much useless against every poison type or ghost type opponent. If it knew sucker punch, however, then the only Pokemon that can possibly resist all its attacks would be other poison fighting types. If you have to choose one, then use sucker punch.